rdblue commented on a change in pull request #351: Extend Iceberg with a way to
overwrite files for eager updates/deletes
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r313646140
##########
File path: core/src/main/java/org/apache/iceberg/OverwriteData.java
##########
@@ -27,10 +30,15 @@
import org.apache.iceberg.expressions.StrictMetricsEvaluator;
public class OverwriteData extends MergingSnapshotProducer<OverwriteFiles>
implements OverwriteFiles {
- private boolean validateAddedFiles = false;
+ private boolean overwriteByRowFilter;
+ private boolean validateAddedFilesMatchRowFilter;
+ private boolean deleteFilesByPath;
+ private Long readSnapshotId;
+ private Expression conflictingAppendsRowFilter;
protected OverwriteData(TableOperations ops) {
super(ops);
+ failMissingDeletePaths();
Review comment:
Is this always required? It seems like it might only be needed when
validating conflicting operations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
