rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313961073
########## File path: api/src/main/java/org/apache/iceberg/expressions/Literals.java ########## @@ -109,6 +110,26 @@ public T value() { public String toString() { return String.valueOf(value); } + + @Override + @SuppressWarnings("unchecked") + public boolean equals(Object other) { Review comment: Is this still needed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org