rdblue commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313964026
##########
File path: api/src/main/java/org/apache/iceberg/expressions/Predicate.java
##########
@@ -19,15 +19,49 @@
package org.apache.iceberg.expressions;
+import com.google.common.base.Preconditions;
+import java.util.Set;
+
public abstract class Predicate<T, R extends Reference> implements Expression {
private final Operation op;
private final R ref;
private final Literal<T> literal;
+ private final LiteralSet<T> literalSet;
Review comment:
I think the only place where these are used is in `toString`, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
