rdblue commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313961395
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java
##########
@@ -89,12 +93,12 @@ public R or(R leftResult, R rightResult) {
return null;
}
- public <T> R in(BoundReference<T> ref, Literal<T> lit) {
- return null;
+ public <T> R in(BoundReference<T> ref, LiteralSet<T> literalSet) {
Review comment:
I don't think this needs to leak the `LiteralSet` implementation class
through the public API. That should be a package-private class and this can use
`Set<T>` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
