rdblue commented on a change in pull request #398: Push down StringStartsWith
in Spark IcebergSource
URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317264772
##########
File path:
api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java
##########
@@ -42,18 +42,19 @@
import static org.apache.iceberg.expressions.Expressions.notEqual;
import static org.apache.iceberg.expressions.Expressions.notNull;
import static org.apache.iceberg.expressions.Expressions.or;
+import static org.apache.iceberg.expressions.Expressions.startsWith;
import static org.apache.iceberg.types.Conversions.toByteBuffer;
import static org.apache.iceberg.types.Types.NestedField.optional;
import static org.apache.iceberg.types.Types.NestedField.required;
public class TestInclusiveMetricsEvaluator {
private static final Schema SCHEMA = new Schema(
required(1, "id", IntegerType.get()),
- optional(2, "no_stats", Types.IntegerType.get()),
- required(3, "required", Types.StringType.get()),
- optional(4, "all_nulls", Types.StringType.get()),
- optional(5, "some_nulls", Types.StringType.get()),
- optional(6, "no_nulls", Types.StringType.get())
+ optional(2, "no_stats", IntegerType.get()),
+ required(3, "required", StringType.get()),
+ optional(4, "all_nulls", StringType.get()),
+ optional(5, "some_nulls", StringType.get()),
+ optional(6, "no_nulls", StringType.get())
Review comment:
Nit: this is an unnecessary change that could cause commit conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
