rdblue commented on a change in pull request #398: Push down StringStartsWith
in Spark IcebergSource
URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317265081
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java
##########
@@ -339,6 +342,48 @@ public Boolean or(Boolean leftResult, Boolean
rightResult) {
return ROWS_MIGHT_MATCH;
}
+ @Override
+ @SuppressWarnings("unchecked")
+ public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
+ int id = ref.fieldId();
+
+ Long valueCount = valueCounts.get(id);
+ if (valueCount == null) {
+ // the column is not present and is all nulls
+ return ROWS_CANNOT_MATCH;
+ }
+
+ Statistics<Binary> colStats = (Statistics<Binary>) stats.get(id);
Review comment:
I don't think this is safe because truncation happens differently for
strings and binary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
