rdblue commented on a change in pull request #398: Push down StringStartsWith
in Spark IcebergSource
URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317842139
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java
##########
@@ -153,6 +156,11 @@ public static Expression convert(Filter filter) {
}
return null;
}
+
+ case STARTS_WITH: {
+ StringStartsWith stringStartsWith = (StringStartsWith) filter;
+ return startsWith(stringStartsWith.attribute(),
stringStartsWith.value());
+ }
Review comment:
Is there a good way to test this conversion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
