rdblue commented on a change in pull request #398: Push down StringStartsWith
in Spark IcebergSource
URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317836527
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
##########
@@ -294,6 +294,11 @@ public Boolean or(Boolean leftResult, Boolean
rightResult) {
return ROWS_MIGHT_MATCH;
}
+ @Override
+ public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
+ return ROWS_MIGHT_MATCH;
Review comment:
I think this can be implemented. If any dictionary value starts with the
prefix, then some row will match. But if all dictionary values do not start
with the prefix, then the row group can be skipped. (This would also need to
check `isFallback` and return `ROWS_MIGHT_MATCH` if so)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
