rdblue commented on a change in pull request #695: [WIP] Cherrypick snapshot
feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r364403672
##########
File path: api/src/main/java/org/apache/iceberg/ManageSnapshots.java
##########
@@ -20,17 +20,27 @@
package org.apache.iceberg;
import org.apache.iceberg.exceptions.CommitFailedException;
-
/**
- * API for rolling table data back to the state at an older table {@link
Snapshot snapshot}.
- * <p>
- * This API does not allow conflicting calls to {@link #toSnapshotId(long)} and
- * {@link #toSnapshotAtTime(long)}.
- * <p>
- * When committing, these changes will be applied to the current table
metadata. Commit conflicts
- * will not be resolved and will result in a {@link CommitFailedException}.
+ * API for managing snapshots. Allows rolling table data back to a stated at
an older table {@link Snapshot snapshot}.
+ * Rollback:
+ * <p>
+ * This API does not allow conflicting calls to {@link #rollback(long)} and
+ * {@link #rollbackAtTime(long)}.
+ * <p>
+ * When committing, these changes will be applied to the current table
metadata. Commit conflicts
+ * will not be resolved and will result in a {@link CommitFailedException}.
+ * Cherrypick:
+ * <p>
+ * In an audit workflow, new data is written to an orphan {@link Snapshot
snapshot} that is not committed as
+ * the table's current state until it is audited. After auditing a change, it
may need to be applied or cherry-picked
+ * on top of the latest snapshot instead of the one that was current when the
audited changes were created.
+ * This class adds support for cherry-picking the changes from an orphan
snapshot by applying them to
+ * the current snapshot. The output of the operation is a new snapshot with
the changes from cherry-picked
+ * snapshot.
+ * <p>
*/
-public interface Rollback extends PendingUpdate<Snapshot> {
+
Review comment:
Nit: This newline should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
