rdblue commented on a change in pull request #695: [WIP] Cherrypick snapshot
feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r364416580
##########
File path: api/src/main/java/org/apache/iceberg/ManageSnapshots.java
##########
@@ -48,6 +58,7 @@
* @return this for method chaining
* @throws IllegalArgumentException If the table has no old snapshot before
the given timestamp
*/
- Rollback toSnapshotAtTime(long timestampMillis);
+ ManageSnapshots rollbackAtTime(long timestampMillis);
Review comment:
Can we rename this to `rollbackToTime`? I think that wording is a little
more natural.
While we're changing this API, I think we should also be a bit more careful
about behavior. Should this roll back to the snapshot that was current at the
given time, or to the snapshot that was committed just before the given time
that is an ancestor of the current state? For example, say I have snapshots A,
B, and C committed in that order, while my table history is A, B, C, B. If I
roll back to a time when C was current, should this use B (because C is not an
ancestor of the current state) or should this use C because it was current at
the time? I'm leaning toward using only snapshots that are ancestors of the
current table state, but I'd like to hear other opinions on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
