rdblue commented on a change in pull request #695: [WIP] Cherrypick snapshot
feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r364414781
##########
File path: api/src/main/java/org/apache/iceberg/ManageSnapshots.java
##########
@@ -39,7 +49,7 @@
* @return this for method chaining
* @throws IllegalArgumentException If the table has no snapshot with the
given id
*/
- Rollback toSnapshotId(long snapshotId);
+ ManageSnapshots rollback(long snapshotId);
Review comment:
I think we should use `setCurrentSnapshot` instead of `rollback` because
this doesn't need to check that the snapshot is an ancestor. Alternatively, we
could have both and make the `rollbackTo` version check that the given snapshot
_is_ an ancestor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
