aokolnychyi commented on a change in pull request #675: Inherit snapshot ids 
for manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r371890934
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
 ##########
 @@ -144,8 +144,9 @@ private ManifestReadTask(FileIO io, FileScanTask 
manifestTask, Schema schema) {
 
     @Override
     public CloseableIterable<StructLike> rows() {
+      String manifestPath = manifestTask.file().path().toString();
       return CloseableIterable.transform(
-          
ManifestReader.read(io.newInputFile(manifestTask.file().path().toString())).project(schema),
+          
ManifestReader.readEntries(io.newInputFile(manifestPath)).project(schema),
 
 Review comment:
   I've updated metadata tables to get rid of `readEntries`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to