aokolnychyi commented on a change in pull request #675: Inherit snapshot ids
for manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r371895792
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##########
@@ -295,7 +305,10 @@ private WriterWrapper getWriter(Object key) {
@Override
protected void cleanUncommitted(Set<ManifestFile> committed) {
cleanUncommitted(newManifests, committed);
- cleanUncommitted(addedManifests, committed);
+ if (!snapshotIdInheritanceEnabled) {
Review comment:
Yes, the summary is correct. In `MergingSnapshotProducer`, though, we can
merge the appended manifest while preparing a new snapshot and it will never be
part of the table metadata. That's why we have an extra loop through added
manifests that were not rewritten.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
