aokolnychyi commented on a change in pull request #675: Inherit snapshot ids
for manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r372414374
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##########
@@ -162,10 +178,14 @@ private ManifestFile copyManifest(ManifestFile manifest)
{
validateFilesCounts();
+ // TODO: add sequence numbers here
+ Iterable<ManifestFile> newManifestsWithMetadata = Iterables.transform(
Review comment:
This place requires attention. When we introduce sequence numbers, we will
have to iterate through all new manifests. For now, iterating through
`newManifests` and `rewrittenAddedManifests` is redundant. However, I expect we
will add sequence number quickly and we will simply need to change the closure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
