aokolnychyi commented on code in PR #8227: URL: https://github.com/apache/iceberg/pull/8227#discussion_r1294910995
########## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/MigrateTableSparkAction.java: ########## @@ -56,17 +56,16 @@ public class MigrateTableSparkAction extends BaseTableCreationSparkAction<Migrat private final StagingTableCatalog destCatalog; private final Identifier destTableIdent; - private final Identifier backupIdent; private boolean dropBackup = false; + private String backupTableName = ""; Review Comment: What about placing this var next to `dropBackup`? Both of them are non-final variables that can be overridden. Also, what about just making `Identifier backupIdent` non-final but keeping the type and the initialization in the constructor? We can call construct an identifier in `withBackupTableName`. That way, we should be able to reduce the amount of changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
