aokolnychyi commented on code in PR #8227:
URL: https://github.com/apache/iceberg/pull/8227#discussion_r1297663869
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/MigrateTableSparkAction.java:
##########
@@ -102,6 +102,14 @@ public MigrateTableSparkAction dropBackup() {
return this;
}
+ @Override
+ public MigrateTableSparkAction withBackupTableName(String tableName) {
+ if (!tableName.isEmpty()) {
Review Comment:
This behavior for checking if `tableName` is empty seems a bit weird to me.
If this method is called, I assume someone wants to override the backup table
name. I think we should just go ahead and set `backupIdent`.
I know destination and source identifiers are the same but it would be more
readable to use `sourceTableIdent` in this case. We are backing up the source
table, not the destination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
