amogh-jahagirdar commented on code in PR #8525:
URL: https://github.com/apache/iceberg/pull/8525#discussion_r1332211584
##########
core/src/test/java/org/apache/iceberg/TestDeleteFiles.java:
##########
@@ -412,6 +414,34 @@ public void testDeleteWithCollision() {
afterDeletePartitions);
}
+ @Test
+ public void testDeleteValidateFileExistence() {
+ commit(table, table.newFastAppend().appendFile(FILE_B), branch);
+ Assertions.assertThatThrownBy(
Review Comment:
I'm working on adding a test which does the rewriteDataFiles + deleteFiles
concurrently as well ( the scenario in the description), but I think the same
idea applies for concurrent deletes. Concurrent deletes with validation enabled
should still fail because one delete will succeed, and then one which has to
retry will fail the validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
