rdblue commented on code in PR #8525:
URL: https://github.com/apache/iceberg/pull/8525#discussion_r1332251519
##########
api/src/main/java/org/apache/iceberg/DeleteFiles.java:
##########
@@ -81,4 +81,12 @@ default DeleteFiles deleteFile(DataFile file) {
* @return this for method chaining
*/
DeleteFiles caseSensitive(boolean caseSensitive);
+
+ /**
+ * Enables validation that any files that are part of the deletion still
exist when committing the
+ * operation.
+ *
+ * @return this for method chaining
+ */
+ DeleteFiles validateFilesExist();
Review Comment:
Instead of making an exception in revapi, we need to add a default
implementation of this method that throws `UnsupportedOperationException`. That
avoids the breaking API change and is fine because we don't expect anyone to be
implementing these methods. In any case, if an implementation does exist then
throwing is the right thing to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
