amogh-jahagirdar commented on code in PR #8525:
URL: https://github.com/apache/iceberg/pull/8525#discussion_r1332220229
##########
core/src/test/java/org/apache/iceberg/TestDeleteFiles.java:
##########
@@ -412,6 +414,34 @@ public void testDeleteWithCollision() {
afterDeletePartitions);
}
+ @Test
+ public void testDeleteValidateFileExistence() {
+ commit(table, table.newFastAppend().appendFile(FILE_B), branch);
+ Assertions.assertThatThrownBy(
Review Comment:
Yes you're right. we just care about checking the validate API behavior in
these tests. So we can do one call which performs the delete with validation
(to make sure validation does not fail here) followed by another call with
validation which should fail. The concurrency part is not really relevant in
terms of outcomes. It does help verify the behavior is as expected when one of
the operation is forced to retry. But again if we just validate the validation
works as expected, that's more of a timing detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
