amogh-jahagirdar commented on code in PR #8525:
URL: https://github.com/apache/iceberg/pull/8525#discussion_r1332273688
##########
api/src/main/java/org/apache/iceberg/DeleteFiles.java:
##########
@@ -81,4 +81,12 @@ default DeleteFiles deleteFile(DataFile file) {
* @return this for method chaining
*/
DeleteFiles caseSensitive(boolean caseSensitive);
+
+ /**
+ * Enables validation that any files that are part of the deletion still
exist when committing the
+ * operation.
+ *
+ * @return this for method chaining
+ */
+ DeleteFiles validateFilesExist();
Review Comment:
Good point, we can totally avoid breaking the `DeleteFile` API change.
anyone who happens to be implementing this isn't forced to override it until
they actually need a validation behavior. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
