rdblue opened a new pull request #1080:
URL: https://github.com/apache/iceberg/pull/1080


   This replaces all calls to Snapshot.manifests with calls to one of 3 new 
methods:
   * `Snapshot.allManifests` returns both delete and data manifests
   * `Snapshot.deleteManifests` returns only delete manifests
   * `Snapshot.dataManifests` returns only data manifests
   
   Existing references mostly use either `allManifests` or `dataManifests`, 
depending on the context. For example, tests with assertions for the number of 
manifests use `allManifests` because the test cases should validate there are 
no new delete manifests, but other tests that validate rewritten manifests are 
deleted use `dataManifests` because only data manifests are rewritten and 
deleted.
   
   This tries to make minimal changes that preserve the current behavior. 
Operations are not updated to support delete manifests (rewrite still only 
rewrites data manifests), but will carry through the list of delete manifests 
correctly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to