rdblue commented on a change in pull request #1080:
URL: https://github.com/apache/iceberg/pull/1080#discussion_r434000639
##########
File path: core/src/test/java/org/apache/iceberg/TableTestBase.java
##########
@@ -224,10 +224,10 @@ void validateSnapshot(Snapshot old, Snapshot snap, long
sequenceNumber, DataFile
}
void validateSnapshot(Snapshot old, Snapshot snap, Long sequenceNumber,
DataFile... newFiles) {
- List<ManifestFile> oldManifests = old != null ? old.manifests() :
ImmutableList.of();
+ List<ManifestFile> oldManifests = old != null ? old.dataManifests() :
ImmutableList.of();
Review comment:
My reasoning was that the signature of this method is `DataFile...
newFiles`, so callers can't pass `DeleteFile`. But, I could add an assertion
that `deleteManifests()` is empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
