rdblue commented on a change in pull request #1080:
URL: https://github.com/apache/iceberg/pull/1080#discussion_r432792134
##########
File path: core/src/main/java/org/apache/iceberg/FindFiles.java
##########
@@ -197,7 +197,7 @@ public Builder inPartitions(PartitionSpec spec,
List<StructLike> partitions) {
}
// when snapshot is not null
- CloseableIterable<ManifestEntry<DataFile>> entries = new
ManifestGroup(ops.io(), snapshot.manifests())
+ CloseableIterable<ManifestEntry<DataFile>> entries = new
ManifestGroup(ops.io(), snapshot.dataManifests())
Review comment:
The contract for this class is to return matching data files, not
splits. We use it in some cases to avoid `newScan` that will return either
`FileScanTask` or `CombinedScanTask` and will emit a scan event. I think we may
be able to remove it, or update it to return both data and delete files. For
now, this uses `dataManifests` to mimic the current behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
