rdblue commented on a change in pull request #1080:
URL: https://github.com/apache/iceberg/pull/1080#discussion_r434001803
##########
File path: core/src/main/java/org/apache/iceberg/ScanSummary.java
##########
@@ -159,7 +159,7 @@ private void removeTimeFilters(List<Expression>
expressions, Expression expressi
removeTimeFilters(filters, Expressions.rewriteNot(scan.filter()));
Expression rowFilter = joinFilters(filters);
- Iterable<ManifestFile> manifests = table.currentSnapshot().manifests();
+ Iterable<ManifestFile> manifests =
table.currentSnapshot().dataManifests();
Review comment:
This whole class will need to be updated to support detecting changes in
delete files, so I just did the minimum to update it safely. Since it uses
`ManifestFiles.read` later instead of `ManifestFiles.readDeletes`, it made
sense to only use data manifests. This is one that we should plan to update in
a separate PR, if anyone is using it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
