rdblue commented on a change in pull request #1080:
URL: https://github.com/apache/iceberg/pull/1080#discussion_r434051120
##########
File path: core/src/main/java/org/apache/iceberg/BaseSnapshot.java
##########
@@ -120,14 +122,42 @@ public String operation() {
return summary;
}
- @Override
- public List<ManifestFile> manifests() {
- if (manifests == null) {
+ private void cacheManifests() {
Review comment:
No. The main problem in #219 was that the lazy value was set before it
was completely initialized. Here, `allManifests` is set to a list that will not
change.
In that PR, we also added double checking and a lock to prevent two threads
from building the same value. We could do that here as well, but it doesn't
affect correctness. There is just a race condition to produce the same sets of
manifests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
