rdblue commented on a change in pull request #1080:
URL: https://github.com/apache/iceberg/pull/1080#discussion_r434005580
##########
File path: core/src/main/java/org/apache/iceberg/AllManifestsTable.java
##########
@@ -136,7 +136,7 @@ protected long targetSplitSize(TableOperations ops) {
} else {
return StaticDataTask.of(
ops.io().newInputFile(ops.current().file().location()),
- snap.manifests(),
+ snap.dataManifests(), // if the manifest list is missing, the
table must be v1 and has no delete manifests
Review comment:
This else block is taken when manifests aren't kept in a file and are
embedded in table metadata. That's not allowed in v2, so delete manifests and
this code path will not happen at the same time.
We could be more explicit and use `allManifests`, so that this fails if a
delete manifest is found. That's probably easier to understand and safer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
