aokolnychyi commented on a change in pull request #1080:
URL: https://github.com/apache/iceberg/pull/1080#discussion_r434008506
##########
File path: core/src/main/java/org/apache/iceberg/BaseSnapshot.java
##########
@@ -120,14 +122,42 @@ public String operation() {
return summary;
}
- @Override
- public List<ManifestFile> manifests() {
- if (manifests == null) {
+ private void cacheManifests() {
Review comment:
Do we have to reason about thread safety like we do in `PartitionSpec`,
for example?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
