rdblue commented on a change in pull request #1080:
URL: https://github.com/apache/iceberg/pull/1080#discussion_r434007525
##########
File path: api/src/main/java/org/apache/iceberg/Snapshot.java
##########
@@ -64,13 +64,25 @@
long timestampMillis();
/**
- * Return the location of all manifests in this snapshot.
- * <p>
- * The current table is made of the union of the data files in these
manifests.
+ * Return all {@link ManifestFile} instances for either data or delete
manifests in this snapshot.
+ *
+ * @return a list of ManifestFile
+ */
+ List<ManifestFile> allManifests();
Review comment:
The question is where we want to make the breaking changes. The format
can't be read correctly without support for deletes, so to support v2 we will
be making some breaking changes. If we do it with API changes then clients will
need to update.
If we just return manifest files for deletes through the old `manifests`
method, then older clients will appear to work until they encounter a delete
manifest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
