rdblue commented on a change in pull request #828:
URL: https://github.com/apache/iceberg/pull/828#discussion_r434873141
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedPageIterator.java
##########
@@ -202,7 +209,7 @@ public int nextBatchFloats(
if (actualBatchSize <= 0) {
return 0;
}
- if (eagerDecodeDictionary) {
+ if (dictionaryDecodeMode == DictionaryDecodeMode.EAGER) {
Review comment:
Coverage shows that this branch isn't taken -- line 213 is never used by
the existing tests. The equivalent line for doubles is taken, though. Can you
find out what's happening?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
