rdblue commented on a change in pull request #828:
URL: https://github.com/apache/iceberg/pull/828#discussion_r434904728
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -178,6 +195,30 @@ public StructType readSchema() {
return lazyType();
}
+ /**
+ * This is called in the Spark Driver when data is to be materialized into
{@link ColumnarBatch}
+ */
+ @Override
+ public List<InputPartition<ColumnarBatch>> planBatchInputPartitions() {
Review comment:
I don't see a test for this. Can you update some of the Spark tests to
run both vectorized and non-vectorized? We can also do this in a follow-up, but
we need to make sure that this code path is being tested as thoroughly as the
non-vectorized code path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
