rdblue commented on a change in pull request #828:
URL: https://github.com/apache/iceberg/pull/828#discussion_r434903734
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -310,26 +379,27 @@ private static void mergeIcebergHadoopConfs(
@Override
public String toString() {
return String.format(
- "IcebergScan(table=%s, type=%s, filters=%s, caseSensitive=%s)",
- table, lazySchema().asStruct(), filterExpressions, caseSensitive);
+ "IcebergScan(table=%s, type=%s, filters=%s, caseSensitive=%s,
batchedReads=%s)",
+ table, lazySchema().asStruct(), filterExpressions, caseSensitive,
enableBatchRead());
}
- private static class ReadTask implements InputPartition<InternalRow>,
Serializable {
- private final CombinedScanTask task;
+ @SuppressWarnings("checkstyle:VisibilityModifier")
Review comment:
Then the `planBatchInputPartitions` method is updated like this:
```java
readTasks.add(new ReadTask<>(
task, tableSchemaString, expectedSchemaString, io,
encryptionManager, caseSensitive, localityPreferred,
new BatchReaderFactory(batchSize)));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
