nastra commented on code in PR #9963:
URL: https://github.com/apache/iceberg/pull/9963#discussion_r1533456221
##########
aws/src/main/java/org/apache/iceberg/aws/s3/DefaultS3FileIOAwsClientFactory.java:
##########
@@ -54,6 +56,11 @@ public S3Client s3() {
awsClientProperties, s3ClientBuilder))
.applyMutation(s3FileIOProperties::applySignerConfiguration)
.applyMutation(s3FileIOProperties::applyS3AccessGrantsConfigurations)
+ .overrideConfiguration(
+ config ->
+ config.putAdvancedOption(
+ SdkAdvancedClientOption.USER_AGENT_PREFIX,
+ "s3fileio " + IcebergBuild.fullVersion()))
Review Comment:
also maybe worth changing the user agent to `"s3fileio/" +
EnvironmentContext.get()`. That way if you're running Spark/Flink, you'll also
get information about that engine and its version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
