nastra commented on code in PR #9963:
URL: https://github.com/apache/iceberg/pull/9963#discussion_r1537430963
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -819,6 +820,14 @@ public <T extends S3ClientBuilder> void
applyS3AccessGrantsConfigurations(T buil
}
}
+ private static final String S3_FILE_IO_SIGNATURE = "s3fileio/" +
EnvironmentContext.get();
Review Comment:
this should be defined at the top of the file (after all the other `public
static final` vars) . Also signature seems rather confusing to me. Why not just
use `S3_FILE_IO_USER_AGENT`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
