CsengerG commented on code in PR #9963:
URL: https://github.com/apache/iceberg/pull/9963#discussion_r1537506185
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -819,6 +820,14 @@ public <T extends S3ClientBuilder> void
applyS3AccessGrantsConfigurations(T buil
}
}
+ private static final String S3_FILE_IO_SIGNATURE = "s3fileio/" +
EnvironmentContext.get();
Review Comment:
Ack, thanks! In my mind signature/fingerprint a software leaves after it
touched something mean the same thing, but the term signature also has uses in
cryptography and AuthN so I get the confusion.
I agree that user agent will be more descriptive here, changed it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
