CsengerG commented on code in PR #9963:
URL: https://github.com/apache/iceberg/pull/9963#discussion_r1537409548
##########
aws/src/main/java/org/apache/iceberg/aws/s3/DefaultS3FileIOAwsClientFactory.java:
##########
@@ -54,6 +56,11 @@ public S3Client s3() {
awsClientProperties, s3ClientBuilder))
.applyMutation(s3FileIOProperties::applySignerConfiguration)
.applyMutation(s3FileIOProperties::applyS3AccessGrantsConfigurations)
+ .overrideConfiguration(
+ config ->
+ config.putAdvancedOption(
+ SdkAdvancedClientOption.USER_AGENT_PREFIX,
+ "s3fileio " + IcebergBuild.fullVersion()))
Review Comment:
Thanks, these are great callouts!
I factored this lambda out into a separate "mutator" like it is done for the
other configs and included a unit test that at least calls the code. I tried to
introduce some assertions to check if the correct String is set as User Agent
but it felt like I was just re-implementing the original code path with captors
so I abandoned that effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
