rdsr commented on a change in pull request #1197:
URL: https://github.com/apache/iceberg/pull/1197#discussion_r459248613
##########
File path: spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcWriter.java
##########
@@ -42,7 +42,7 @@
* This class acts as an adaptor from an OrcFileAppender to a
* FileAppender<InternalRow>.
*/
-public class SparkOrcWriter implements OrcValueWriter<InternalRow> {
+public class SparkOrcWriter implements OrcRowWriter<InternalRow> {
private final Converter[] converters;
Review comment:
Does it make sense to file a ticket to refactor SparkOrcWriter to
utilize similar approach of using `OrchSchemaVisitor`. This could help with
reuse of common generic writers defined in `GenericOrcWriters`, similar to how
we did in `SparkOrcReaders`?
We can tackle this ticket in future PRs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
