openinx commented on pull request #1197: URL: https://github.com/apache/iceberg/pull/1197#issuecomment-664079522
@rdsr I've refactored the SparkOrcWrier by using OrcSchemaWithTypeVisitor in [here](https://github.com/apache/iceberg/pull/1238/files#diff-5aa4840155ec70fdf7f725e122cde7b7R44), we can see that the constructor of SparkOrcWriter will also need the two arguments: iceberg schema and TypeDescription. So actually, although we could add a `Function` in here, but we actually won't use it in the newly refactored spark orc writer, that's why I say we don't need to introduce the redundant `Function` method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
