rdsr commented on a change in pull request #1197:
URL: https://github.com/apache/iceberg/pull/1197#discussion_r459250716
##########
File path:
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilterTypes.java
##########
@@ -180,7 +180,7 @@ public void createOrcInputFile(List<Record> records) throws
IOException {
OutputFile outFile = Files.localOutput(ORC_FILE);
try (FileAppender<Record> appender = ORC.write(outFile)
.schema(FILE_SCHEMA)
- .createWriterFunc(GenericOrcWriter::buildWriter)
+ .createWriterFunc(typeDesc ->
GenericOrcWriter.buildWriter(FILE_SCHEMA, typeDesc))
Review comment:
Would it make more sense to add `createWriterFunc` method that accepts
`BiFunction<Schema, TypeDescription>` instead of replacing the existing one?
Replacing the existing `createWriterFunc` causes changes in the files?
```
TestSparkOrcReadMetadataColumns.java
TestSparkOrcReader.java
TestOrcWrite.java
SparkAppenderFactory.java
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
