rdsr edited a comment on pull request #1197: URL: https://github.com/apache/iceberg/pull/1197#issuecomment-664049255
@openinx I felt adding a `BiFunction` was better than replacing it. And regarding > That makes more confuse and the OrcFileAppender need to choose the non-null function to create the OrcRowWriter `Avro` handles that well. See `org.apache.iceberg.avro.Avro.ReadBuilder#build` But I'm ok with the patch in its current form. Since @rdblue initiated this comment. I'll wait for his final approval before merging. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
