nastra commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1668392007
##########
data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java:
##########
@@ -44,7 +43,7 @@ public static void assertEquals(Types.StructType struct,
Record expected, Record
public static void assertEquals(Types.ListType list, List<?> expected,
List<?> actual) {
Type elementType = list.elementType();
- Assert.assertEquals("List size should match", expected.size(),
actual.size());
+ assertThat(actual).as("List size should match").hasSize(expected.size());
Review Comment:
```suggestion
assertThat(actual).as("List size should match").hasSameSizeAs(expected);
```
when this assertion fails it will also print the content so that it's easier
to understand why the assertion fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
