openinx commented on pull request #1197: URL: https://github.com/apache/iceberg/pull/1197#issuecomment-665681586
@Simon0806 we won't need to abstract the `BaseOrcWriter` again in this patch because we have [discussed](https://github.com/apache/iceberg/pull/1158#discussion_r451323369) to share the common data type writers in the GenericOrcWriter, FlinkOrcWriter, SparkOrcWriter. That's helpful to decouple the codes for different compute engine. Thanks. BTW, ping @rdblue to merge this patch, Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
