rdblue commented on a change in pull request #1368:
URL: https://github.com/apache/iceberg/pull/1368#discussion_r477445928
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Transforms.java
##########
@@ -192,4 +230,10 @@ private Transforms() {
public static <T> Transform<T, Void> alwaysNull() {
return VoidTransform.get();
}
+
+ private static void checkZoneOffsetIsUTC(ZoneOffset zoneOffset) {
+ Preconditions.checkArgument(zoneOffset == null ||
zoneOffset.getTotalSeconds() == 0,
+ "Expect zone offset is null or UTC, but is", zoneOffset);
Review comment:
The offset should always be null because it is invalid to call `day`
with a date field and a zone offset. Even if the offset is UTC, it is not
allowed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
