zhangdove commented on a change in pull request #1368:
URL: https://github.com/apache/iceberg/pull/1368#discussion_r477143664
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Timestamps.java
##########
@@ -127,6 +133,6 @@ public String toHumanString(Integer value) {
@Override
public String toString() {
- return name;
+ return name + "[" + zoneOffset.getTotalSeconds() + "]";
Review comment:
This way look good to understand,I will change it.
`toString` return `name`, When the value of `zoneOffset.getTotalSeconds() `
is zero . This will also be compatible with the historical version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
