rdblue commented on a change in pull request #1368:
URL: https://github.com/apache/iceberg/pull/1368#discussion_r477443440
##########
File path:
api/src/main/java/org/apache/iceberg/transforms/PartitionSpecVisitor.java
##########
@@ -55,17 +56,24 @@
} else if (transform instanceof Truncate) {
results.add(visitor.truncate(sourceName, field.sourceId(),
((Truncate<?>) transform).width()));
- } else if (transform == Dates.YEAR || transform == Timestamps.YEAR) {
+ } else if (transform == Dates.YEAR || isTimestamp(transform,
ChronoUnit.YEARS)) {
Review comment:
Will users of the visitor not need to know the zone offset?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
