rdblue commented on a change in pull request #1368:
URL: https://github.com/apache/iceberg/pull/1368#discussion_r477447101
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Transforms.java
##########
@@ -57,10 +60,26 @@ private Transforms() {
return Identity.get(type);
}
+ if (type.typeId() == Type.TypeID.TIMESTAMP) {
+ try {
+ Matcher timeZoneOffset = HAS_TIME_OFFSET.matcher(transform);
+ if (timeZoneOffset.matches()) {
+ String name = timeZoneOffset.group(1);
+ String offsetId = timeZoneOffset.group(2);
+ return TimestampTransform.get(type, name.toLowerCase(Locale.ENGLISH))
Review comment:
`TimestampTransform.get` is responsible for handling mixed case, so
there is no need to call `toLowerCase` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
