rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479417990
##########
File path:
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
##########
@@ -46,12 +48,18 @@
private static final String METADATA_FOLDER_NAME = "metadata";
+ private String fullName;
private TableMetadata currentMetadata = null;
private String currentMetadataLocation = null;
private boolean shouldRefresh = true;
private int version = -1;
- protected BaseMetastoreTableOperations() {
+ protected BaseMetastoreTableOperations(String fullName) {
Review comment:
This base class is extended by external projects, so I think we should
avoid breaking changes like this one.
I propose adding a `tableName` method with a base implementation that
returns `null`. Hive can override the implementation to provide the table name
(as could external implementations) and the log message can include the table
name if it is non-null. Does that sound reasonable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
