rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479414455
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -465,9 +495,14 @@ protected void finalize() throws Throwable {
super.finalize();
if (!closed) {
close(); // releasing resources is more important than printing the
warning
- String trace = Joiner.on("\n\t").join(
+ String trace = Joiner.on("\\n\t").join(
Review comment:
@pvary, I'm not sure why, but I've never seen mixed log lines in our
environment. So I don't think it is a good idea to solve the problem for one
environment by making logs harder to read everywhere.
What about using a custom appender or SLF4J binding in your environment that
converts newlines to `\\n` so that you can configure it locally? I think that
is a fairly easy solution that doesn't require changing logs everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
