rdblue commented on a change in pull request #1373:
URL: https://github.com/apache/iceberg/pull/1373#discussion_r479575301
##########
File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java
##########
@@ -251,7 +251,7 @@ public static Expression rewriteNot(Expression expr) {
return ExpressionVisitors.visit(expr, RewriteNot.get());
}
- static <T> NamedReference<T> ref(String name) {
+ public static <T> NamedReference<T> ref(String name) {
Review comment:
It should be fine to pass this in through the factory methods that
accept `Term`, so it's okay to make it public.
It should have Javadoc, though. And it would be helpful to mention that this
is equivalent to using the `Expressions` methods that accept `String`: `The
following are equivalent: equals("a", 5) and equals(ref("a"), 5)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
