rdblue commented on a change in pull request #1373:
URL: https://github.com/apache/iceberg/pull/1373#discussion_r479579364
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -94,9 +105,15 @@ static TableMetadata newTableMetadata(Schema schema,
}
PartitionSpec freshSpec = specBuilder.build();
+ // TODO: case sensitivity
Review comment:
I don't think this would be a problem unless the schema passed in is not
the schema used to create the spec or sort order. If it is the same, then the
case sensitive check will always work. If not, then we could have an error when
we can't find the name when rebuilding for the schema with fresh IDs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
