rdblue commented on a change in pull request #1373:
URL: https://github.com/apache/iceberg/pull/1373#discussion_r479582656



##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -61,18 +63,27 @@ public static TableMetadata 
newTableMetadata(TableOperations ops,
                                                PartitionSpec spec,
                                                String location,
                                                Map<String, String> properties) 
{
-    return newTableMetadata(schema, spec, location, properties, 
DEFAULT_TABLE_FORMAT_VERSION);
+    return newTableMetadata(schema, spec, SortOrder.unsorted(), location, 
properties, DEFAULT_TABLE_FORMAT_VERSION);

Review comment:
       This class might be a good one for a builder as well...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to